On 3 July 2017 at 23:47, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > On Mon, Jul 03 2017, Francesco Mazzoli jotted: > > > The flag can be overridden with `--no-force-with-lease`, or by > > passing the config via the command line. > > Thanks for hacking on this. A couple of things: > > * Most things (but not all) that configure `git whatevs --some-option` > are configurable via whatevs.someOption, I think this should follow > that convention. I.e. be push.forceWithLease not > push.alwaysForceWithLease. > > See my > https://public-inbox.org/git/20170324231013.23346-1-avarab@xxxxxxxxx/ > patch series for something that went through many of these cases > (although I see I didn't send it all to list). Anyway, something like > 8/10 of our config variables for switches follow that > convention. Let's use it for new config. OK, my worry was about the fact that if I call it like the option I'd better support the full range of options available to `--force-with-lease`. Anyway, I'll change the name. > * It makes sense to also document this the git-push manpage. See > e.g. how we document --follow-tags: > > Push all the refs that [...] This can also be specified with > configuration variable push.followTags. For more information, see > push.followTags in git-config(1). > > You should add something like that to --force-with-lease. OK, will do.
