v3: * fixed first patch to call the data 'caller provided' instead of arbitrary. * moved the position of the caller provided data to first position * split up the rather mechanical change of function signature with fixing the API usage of patch-ids.c v2: addressed all but the last point of Jonathan Nieder. Thanks, Stefan v1: https://public-inbox.org/git/xmqqpodnvmmw.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/ for context why we need a new data field. Implement that. Once upon a time we had a long discussion where to put documentation best. The answer was header files as there documentation has less chance to become stale and be out of date. Improve the docs by * migrating them to the header * clarifying how the compare function is to be used * how the arguments to hashmap_get/remove should be used. Thanks, Stefan Stefan Beller (3): hashmap.h: compare function has access to a data field patch-ids.c: use hashmap correctly hashmap: migrate documentation from Documentation/technical into header Documentation/technical/api-hashmap.txt | 309 --------------------------- attr.c | 7 +- builtin/describe.c | 8 +- builtin/difftool.c | 24 ++- builtin/fast-export.c | 7 +- config.c | 9 +- convert.c | 3 +- diffcore-rename.c | 2 +- hashmap.c | 17 +- hashmap.h | 360 ++++++++++++++++++++++++++++---- name-hash.c | 16 +- oidset.c | 5 +- patch-ids.c | 10 +- refs.c | 5 +- remote.c | 7 +- sha1_file.c | 5 +- sub-process.c | 7 +- sub-process.h | 6 +- submodule-config.c | 14 +- t/helper/test-hashmap.c | 19 +- 20 files changed, 431 insertions(+), 409 deletions(-) delete mode 100644 Documentation/technical/api-hashmap.txt -- 2.13.0.31.g9b732c453e
