Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > On Tue, Jun 27 2017, Junio C. Hamano jotted: > >> Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >> >>> A v2 addressing comments to the v1, tbdiff below. Just fixes the >>> subject line on 1/3 & gets rid of the redundant _BIG_ENDIAN detection >>> for Solaris, we can just use __sparc (and indeed we did before this). >> >> Thanks. Let's have this tested by minority platform folks to help >> the upstream digest your pull request. The change since the last >> round makes perfect sense to me. > > Just a brief update. This has been found not to work on some BSDs (with > older GCC), but there's a patch being discussed at > https://github.com/cr-marcstevens/sha1collisiondetection/pull/34 > > The discussion is sorted out, just waiting on n-soda to submit a patch > (or to tell me he'd like me to), then the known issues will be fixed & > it should be merged quickly, then I'll submit a v3. Thanks. It's good that I learned to pretend that I didn't hear anything like I'm pretty sure this un-breaks everything & doesn't regress on cases where we fixed things earlier. from anybody, and instead wait a bit longer ;-)
