Re: [PATCH v6 6/6] convert: add "status=delayed" to filter process protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 27 Jun 2017, at 00:13, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> 
> Lars Schneider <larsxschneider@xxxxxxxxx> writes:
> 
>> ...
> 
>>> I am wondering whose responsibility it will be to deal with a path
>>> "list-available" reports that are *not* asked by Git or Git got no
>>> "delayed" response.  The list subtraction done by the caller is
>>> probably the logical place to do so.
>> 
>> Correct. Git (the caller) will notice that not all "delayed" paths
>> are listed by the filter and throw an error at the end.
> 
> I am wondering about the other case.  Git didn't ask for a path to
> be filtered at all, but the filter sneaked in a path that happens to
> in the index in its response---Git should at least ignore it, and
> better yet, diagnose it as an error in the filter process.

Agreed. I've used your implementation suggestion [1] and added two
test cases to ensure we signal a proper error in case of a buggy filter.

Thanks,
Lars


[1] http://public-inbox.org/git/xmqqzicu2x4a.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux