James Clarke <jrtc27@xxxxxxxxxx> writes: > The preceding bitmap entries have a 1-byte XOR-offset and 1-byte flags, > so their size is not a multiple of 4. Thus the name-hash cache is only > guaranteed to be 2-byte aligned and so we must use get_be32 rather than > indexing the array directly. > > Signed-off-by: James Clarke <jrtc27@xxxxxxxxxx> > --- > > This was noticed thanks to the recent tests added to t5310-pack-bitmaps.sh, > which were crashing with SIGBUS on Debian sparc64. All tests (excluding those > marked with known breakage) now pass again. Thanks. > > pack-bitmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pack-bitmap.c b/pack-bitmap.c > index a3ac3dccd..327634cd7 100644 > --- a/pack-bitmap.c > +++ b/pack-bitmap.c > @@ -627,7 +627,7 @@ static void show_objects_for_type( > sha1 = nth_packed_object_sha1(bitmap_git.pack, entry->nr); > > if (bitmap_git.hashes) > - hash = ntohl(bitmap_git.hashes[entry->nr]); > + hash = get_be32(bitmap_git.hashes + entry->nr); > > show_reach(sha1, object_type, 0, hash, bitmap_git.pack, entry->offset); > } > -- > 2.13.2
