On Mon, Jun 19, 2017 at 06:03:13PM -0700, Jonathan Tan wrote: > Subject: [PATCH v4 6/8] sha1_file: improve sha1_object_info_extended > Improve sha1_object_info_extended() by supporting additional flags. This > allows has_sha1_file_with_flags() to be modified to use > sha1_object_info_extended() in a subsequent patch. A minor nit, but try to avoid vague words like "improve" in your subject lines. Something like: sha1_file: teach sha1_object_info_extended more flags That's not too specific either, but I think in --oneline output it gives you a much better clue about what part of the function it touches. > --- > cache.h | 4 ++++ > sha1_file.c | 43 ++++++++++++++++++++++++------------------- > 2 files changed, 28 insertions(+), 19 deletions(-) The patch itself looks good. -Peff
