On Fri, Jun 23, 2017 at 09:01:38AM +0200, Michael Haggerty wrote: > Add the infrastructure to make `packed_ref_store` implement > `ref_store`, at least formally (few of the methods are actually > implemented yet). Change the functions in its interface to take > `ref_store *` arguments. Change `files_ref_store` to store a pointer > to `ref_store *` and to call functions via the virtual `ref_store` > interface where possible. This also means that a few > `packed_ref_store` functions can become static. By itself this looks correct (as do the patches leading up to it). But I think some of the "big picture" is lost. Why do we want it to look like a ref store? I suspect the answer is too big to go into this individual commit message. But I went back and re-read the cover letter, and I don't think it's really explained there, either. So I'm not really sure where it ought to be covered (or if I simply missed it somewhere, or if it's coming up; I'm reading the patches linearly). -Peff
