Re: [PATCH v2 01/29] t1408: add a test of stale packed refs covered by loose refs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 23, 2017 at 09:01:19AM +0200, Michael Haggerty wrote:

> +test_expect_success setup '
> +	test_tick &&
> +	git commit --allow-empty -m one &&
> +	one=$(git rev-parse HEAD) &&
> +	git for-each-ref >actual &&
> +	echo "$one commit	refs/heads/master" >expect &&
> +	test_cmp expect actual &&
> +
> +	git pack-refs --all &&
> +	git for-each-ref >actual &&
> +	echo "$one commit	refs/heads/master" >expect &&
> +	test_cmp expect actual &&
> +
> +	cat .git/packed-refs &&

I think we'd usually drop debugging "cat"s like these in the name of
keeping the process count down. Unless they really are intended to
confirm that .git/packed-refs exists (although test_path_is_file is a
less expensive way of checking that).

That's a minor nit, though.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux