On Thu, Jun 22, 2017 at 9:53 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Christian Couder <christian.couder@xxxxxxxxx> writes: > >> Add a test to check that both the split-index file and the >> shared-index file are created using the right permissions >> when core.sharedrepository is set. >> >> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> >> --- >> t/t1700-split-index.sh | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh >> index af3ec0da5a..a52b92e82b 100755 >> --- a/t/t1700-split-index.sh >> +++ b/t/t1700-split-index.sh >> @@ -370,4 +370,16 @@ test_expect_success 'check splitIndex.sharedIndexExpire set to "never" and "now" >> test $(ls .git/sharedindex.* | wc -l) -le 2 >> ' >> >> +test_expect_success POSIXPERM 'split index respects core.sharedrepository' ' >> + git config core.sharedrepository 0666 && >> + : >seventeen && >> + git update-index --add seventeen && >> + echo "-rw-rw-rw-" >expect && >> + test_modebits .git/index >actual && >> + test_cmp expect actual && >> + newest_shared_index=$(ls -t .git/sharedindex.* | head -1) && > > Hmph. Don't you want to make sure all of them, not just the latest > one, have the expected mode bits? We use "git config core.sharedrepository 0666" at the beginning of this test, so it will only apply to the shared index files that are created after that. Do you suggest that we test before setting core.sharedrepository that the existing shared index files all have the default permissions?
