Re: [PATCH v3 15/20] repository: add index_state to struct repo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/21, Jonathan Tan wrote:
> On Tue, 20 Jun 2017 12:19:46 -0700
> Brandon Williams <bmwill@xxxxxxxxxx> wrote:
> 
> > +int repo_read_index(struct repository *repo)
> > +{
> > +	if (!repo->index)
> > +		repo->index = xcalloc(1, sizeof(struct index_state));
> 
> sizeof(*repo->index)?

Is there a reason to prefer one versus the other? Either way I can
change.

> 
> [snip]
> 
> > +	/* Repository's in-memory index */
> > +	struct index_state *index;
> > +
> 
> Might be worth commenting that repo_read_index() can populate this.

-- 
Brandon Williams



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux