Re: [PATCH 17/26] diff.c: convert show_stats to use emit_diff_symbol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>       case DIFF_SYMBOL_SUBMODULE_PIPETHROUGH:
>>               emit_line(o, "", "", line, len);
>>               break;
>> +     case DIFF_SYMBOL_STATS_SUMMARY_NO_FILES:
>> +             fprintf(o->file, " 0 files changed\n");
>
> Why is this one a fprintf call instead of an emit_line call?  I'm sure
> this is intended It just stands out to me.

I am sure it is unintended to stand out in such a way.
Originally I wanted to make it as close 1:1 conversion,
and as we did not emit the line prefix at the time but relied on
the line prefix being emitted prior to when this was printed.
Will convert to emit_line as that seems to be a bug in this patch.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux