Re: [PATCHv2] Tweak help auto-correct phrasing.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017-06-20 02:04 PM, Kaartic Sivaraam wrote:
On Tue, 2016-12-20 at 09:02 -0500, Marc Branchaud wrote:
When auto-correct is enabled, an invalid git command prints a warning
and
a continuation message, which differs depending on whether or not
help.autoCorrect is positive or negative.

With help.autoCorrect = 15:

    WARNING: You called a Git command named 'lgo', which does not
exist.
    Continuing under the assumption that you meant 'log'
    in 1.5 seconds automatically...

With help.autoCorrect < 0:

    WARNING: You called a Git command named 'lgo', which does not
exist.
    Continuing under the assumption that you meant 'log'

The continuation message's phrasing is awkward.  This commit cleans
it up.
As a bonus, we now use full-sentence strings which make translation
easier.

With help.autoCorrect = 15:

    WARNING: You called a Git command named 'lgo', which does not
exist.
    Continuing in 1.5 seconds, assuming that you meant 'log'.

With help.autoCorrect < 0:

    WARNING: You called a Git command named 'lgo', which does not
exist.
    Continuing under the assumption that you meant 'log'.

Signed-off-by: Marc Branchaud <marcnarc@xxxxxxxxxxx>
---

Excuse me for bringing this up after a long time. What's the status of
this patch? Was it applied?

Looks like it got lost in the shuffle.

The topic thread starts at:
	http://public-inbox.org/git/1482063500.10858.1.camel@xxxxxxxxx/

There's no reply to my v2 patch, and I neglected to follow up on it -- sorry!

Shall I resend the patch?

		M.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux