On 5/14/07, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
On Sun, 13 May 2007, Lars Hjemli <hjemli@xxxxxxxxx> wrote: > I've implemented number of files/lines changed in cgit's log view and > pushed it to http://hjemli.net/git/ > > It does consume some cpu (especially on the linux-2.6 repo), but it's > not terribly bad (and the caching helps out). But I felt like changing > the number of commits per page to 50, so I added a knob for this in > the config file while at it. > > I'll try to get a proper diffstat on the commit page + file history > via tree view next (filesize has always been part of cgits tree view > btw). What I lack in cgit is using git diff and showing extended diff headers (and the ugly tight box around diff doesn't help either), and gitweb's 'commitdiff' view / git's git-show / git's git-format-patch.
Yes, this has been lacking. Last night I pushed initial support for 'commitdiff', but it doesn't show git's extended diff headers, nor is there any plain/patch view (but the ugly tiny box is still there, I'm lousy at web design :) That said, extended headers/patch view should be trivial to support so I'll look into it.
I don't think displaying filesize slows cgit much (you need to find and read object header for that, as this information is not present in a tree object...
True, I do type = sha1_object_info(sha1, &size) per entry in tree view to get the size. It's fast.
By the way, what do you think about http://git.or.cz/gitwiki/Gitweb page?
Nice, I hadn't noticed this page, maybe cgit should get one too? Well, it probably should get some users first (are there anyone besides myself?) -- larsh - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
