On Sun, Jun 18, 2017 at 03:39:40PM +0200, Michael Haggerty wrote: > This is v2 of these patches. Thanks to Peff and Junio for their > feedback about v1 [1]. > > Changes since v1: > > * Added a test and tweaked the commit message of the first patch. Thanks, both changes look good to me. > As before, the second patch is optional. If it is omitted, it might > flush out any other bugs like this one in client code. If it is > included, regressions are less likely, but we won't learn about other > misuses of the API. I have no strong opinion either way. My feeling is still slightly towards "don't include", but I also don't have a strong opinion. -Peff