Re: [PATCH 18/28] packed-backend: new module for handling packed references

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 15, 2017 at 7:47 AM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote:
> Now that the interface between `files_ref_store` and
> `packed_ref_store` is relatively narrow, move the latter into a new
> module, "refs/packed-backend.h" and "refs/packed-backend.c". It still
> doesn't quite implement the `ref_store` interface, but it will soon.
>
> This commit moves code around and adjusts its visibility, but doesn't
> change anything.

I did not look into it in detail (as the origin/sb/diff-color-move
series ought to help here, but I am in the mid of rewriting that again
to have a better design; also on my laptop, such that I'd have install
that series).

I think this commit represents another common case of
code movement, where you would not just move around code, but
also add/remove some keywords (e.g. the static word in C, or a class
name changes in Java/C++)

Maybe we would want to not just color up moved blocks but show
the adjacant lines of moved blocks in a word diff (such that the
class name change would be highlighted) in a comment or such.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]