On Thu, Jun 15, 2017 at 12:17:15PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@xxxxxxxxx> writes:
>
> >> contrib/diff-highlight/.gitignore | 2 ++
> >> .../{diff-highlight => DiffHighlight.pm} | 40 +++++++++++++---------
> >> contrib/diff-highlight/Makefile | 21 ++++++++++--
> >> contrib/diff-highlight/README | 30 ++++++++++++++++
> >> contrib/diff-highlight/diff-highlight.perl | 8 +++++
> >> 5 files changed, 82 insertions(+), 19 deletions(-)
> >> create mode 100644 contrib/diff-highlight/.gitignore
> >> rename contrib/diff-highlight/{diff-highlight => DiffHighlight.pm} (91%)
> >> mode change 100755 => 100644
> >> create mode 100644 contrib/diff-highlight/diff-highlight.perl
> >
> > Do you want +x bit for the last one? I could throw that bit in
> > while queuing if you want.
>
> Ah, I do not think you want it, as this is not something to be
> executed as-is (it is a source file, which diff-highlight that is
> executable is made out of).
Yes, exactly. Although many of our .sh files, though generally
"compiled" with the Makefile, still have the executable bit. I don't
mind adding it if we'd rather follow that pattern in general.
-Peff