Re: [PATCH] Require JDK1.5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 14 May 2007, Robin Rosenberg wrote:
This changes project settings to requre Java 5 and
also tightens some compiler settings.

Signed-off-by: Robin Rosenberg <robin.rosenberg@xxxxxxxxxx>
---
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    5 +--
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    5 +--
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    5 +--
.../.settings/org.eclipse.jdt.core.prefs           |   22 ++++++++++---------
.../.settings/org.eclipse.jdt.ui.prefs             |    3 +-
.../src/org/spearce/jgit/lib/ObjectIdMap.java      |    4 +-
9 files changed, 57 insertions(+), 53 deletions(-)
[snip]
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java
index c397a0d..63796fd 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java
@@ -50,9 +50,9 @@ public class ObjectIdMap implements Map {

	public ObjectIdMap(Map sample) {
		try {
-			Method m=sample.getClass().getMethod("clone", null);
+			Method m=sample.getClass().getMethod("clone", (Class[])null);
			for (int i=0; i<256; ++i) {
-				level0[i] = (Map)m.invoke(sample, null);
+				level0[i] = (Map)m.invoke(sample, (Object[])null);
			}
		} catch (IllegalAccessException e) {
			throw new IllegalArgumentException(e);

I wonder why one would need changes like this?

These casts are not needed for anything as far as I can see and your IDE should easily tell you what type that parameter is. No?


Thanks,

Grzegorz Kulewski

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux