Re: [PATCH v1] Configure Git contribution guidelines for github.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andreas Heiduk <asheiduk@xxxxxxxxx> writes:

> Am 15.06.2017 um 18:43 schrieb Junio C Hamano:
>> Another thing that may regress that you did not mention is that we
>> would lose a convenient way to _count_ proposed changes coming via
>> submitGit (i.e. you can simply go to the pull-request page), so that
>> the number can be compared with the number of proposed changes
>> directly made on the mailing list, which would be a good way to
>> gauge how submitGit service is helping our community.  But even for
>> that, you'd need to go to the list to find the denominator
>> (i.e. total number of changes proposed), and by the time you do
>> that, counting the numerator (i.e. those come via submitGit) by
>> finding the telltale sign submitGit leaves in its output among these
>> denominator messages should be trivial.
>
> This numbers can be aquired quite easily if submitGit adds a defined
> trailer to the converted commit message like this:
>
> 	Signed-off-by: Foo Bar <foo@bar>
> 	Submit-git-id: url-or-id-of-pr

I do not think you would want the noise _in_ the log message.  The
"telltale sign" I had in mind was these "signature" lines at the end
of the message:

    --
    https://github.com/git/git/pull/538




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]