On Tue, Jun 13, 2017 at 09:21:30AM -0700, Junio C Hamano wrote:
> > alias.c | 31 ++++++++++++++++++++++++-------
> > git.c | 55 ++++---------------------------------------------------
> > t/t7006-pager.sh | 2 +-
> > 3 files changed, 29 insertions(+), 59 deletions(-)
>
> Happy to see the deletion of all the save/restore-env stuff.
>
> Except for the puzzlement in one paragraph in the log, looks very
> good. Thanks for a pleasant reading.
The whole thing looks good to me, too, though we should decide what to
do with the point that Brandon raised.
As far as the "streamline" puzzlement goes, I'm OK with either of:
- taking your suggestion from the other thread and actually doing that
streamlining, which is one less thing to have to explain
- leaving the code as-is and tweaking the commit message (though it
made sense to me)
-Peff