On Tue, Jun 13, 2017 at 3:07 PM, Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote:
>> +struct diff_line {
>
> Probably should be called diff_emission (or just emission), since these
> may not be full lines.
I think emitted_string would do as well?
>
> Also, can this definition be in the .c file? Callers should use the
> diff_emit_line() below, and not need to know how it is implemented
> internally.
done
>> +#define diff_line_INIT {NULL, NULL, NULL, 0, 0, 0}
>
> Should be DIFF_LINE_INIT (capitalization), and {NULL} is sufficient, I
> think.
done.