On 06/13, Stefan Beller wrote: > On Tue, Jun 13, 2017 at 2:24 AM, Jeff King <peff@xxxxxxxx> wrote: > > > There is a config knob that can disable the (long) hint. But > > I intentionally omitted a config knob to disable the warning > > entirely. Whether the warning is sensible or not is > > generally about context, not about the user's preferences. > > If there's a tool or workflow that adds gitlinks without > > matching .gitmodules, it should probably be taught about the > > new command-line option, rather than blanket-disabling the > > warning. > > > > Signed-off-by: Jeff King <peff@xxxxxxxx> > > --- > > The check for "is this a gitlink" is done by looking for a > > trailing "/" in the added path. This feels kind of hacky, > > but actually seems to work well in practice. > > This whole "slash at the end" thing comes from extensive use > of shell completion adding the slash at the end of a directory > IMHO. (cf. PATHSPEC_STRIP_SUBMODULE_SLASH_* is > the same underlying hack.) I got rid of PATHSPEC_STRIP_SUBMODULE_SLASH_* recently, just an fyi. -- Brandon Williams