Re: [PATCH v1] Configure Git contribution guidelines for github.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 10 Jun 2017, at 09:35, Jeff King <peff@xxxxxxxx> wrote:
> 
> On Fri, Jun 09, 2017 at 10:03:57AM -0700, Jonathan Nieder wrote:
> 
>> Would putting a PULL_REQUEST_TEMPLATE and CONTRIBUTING in the
>> top-level directory work?  If I'm reading
>> https://help.github.com/articles/setting-guidelines-for-repository-contributors/#adding-a-contributing-file
>> correctly then it seems to say the ".github/" prefix is optional.
> 
> Yes, that should work. The ".github" option is there if you don't want
> the cruft at your top-level. I don't mind CONTRIBUTING, but
> PULL_REQUEST_TEMPLATE is kind of gross. :)

I think so, too :)


>> I also find the long source lines hard to read.  Can you say more
>> about how broken lines render in the github.com web interface?  I
>> would have expected github's markdown renderer to behave like others
>> and cope with line wrapping.
> 
> GitHub-Flavored Markdown treats newlines as a line break in the rendered
> output, unlike the original Markdown implementation. I don't like that
> myself, but it was done in the early days after seeing how many people
> accidentally butchered their formatting because they expected the output
> to look more like what they typed.

That's what I had in my memory based on past experience, too. However, 
out of curiosity I just tried it and it looks like they have changed it.
I'll reformat with 80 chars.

- Lars



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]