On Mon, Jun 12, 2017 at 05:49:11PM -0700, Jonathan Nieder wrote: > > Since there is no implementation of the function 'git_config_iter' lets > > stop exporting it and remove the prototype from config.h. > > > > Signed-off-by: Brandon Williams <bmwill@xxxxxxxxxx> > > --- > > config.h | 1 - > > 1 file changed, 1 deletion(-) > > Good eyes. Looks like the function never existed. You can find mention of it on the list[1,2] in early versions of Tanay's patches. I think it was originally intended to be a variant of git_config() that used the cache. But in the end, we made git_config() do that by default (and added git_config_raw as its underlying helper). I just looked that up to satisfy my curiosity. You are right that its implementation never actually got committed, and clearly removing the declaration is the right thing. -Peff [1] http://public-inbox.org/git/1404280905-26763-2-git-send-email-tanayabh@xxxxxxxxx/ [2] http://public-inbox.org/git/xmqqd2dnitm7.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/