On Sat, Jun 10 2017, Junio C. Hamano jotted: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >> >>> Add a test which covers a blindspot in how these tests should assert >>> that negated character classes are allowed or not allowed to match "/" >>> in certain circumstances. >> >> Please make this a bit more explicit, something like >> >> A negated character class that does not include '/', >> e.g. [^a-z], > > oops. I think the class includes '/'; please excuse loose logic in > a "something like" meant as an illustration to show the level of > details expected ;-) Thanks for the feedback. Sorry I'm slightly confused still (after reading this over a couple of times), are you OK with this patch/commit message as-is or would you still like some clarification there?