Hi Brandon,
On Wed, 31 May 2017, Brandon Williams wrote:
> Commit 2185fde56 (config: handle conditional include when $GIT_DIR is
> not set up) added a 'git_dir' field to the config_options struct. Let's
> use this option field explicitly all the time instead of occasionally
> falling back to calling 'git_pathdup("config")' to get the path to the
> local repository configuration. This allows 'go_git_config_sequence()'
> to not implicitly rely on global repository state.
Oh wow. `git_pathdup()`...
Sadly, I lack the time to review the entire patch series, but this here
change definitely looks correct to me.
Thanks,
Dscho