On Tue, Jun 6, 2017 at 8:12 AM, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > This updates sha1dc fixing the issue on Cygwin introduced in 2.13.1, > and hopefully not regressing elsewhere. Liam, it would be much > appreciated if you could test this on SPARC. > > As before the "sha1dc: update from upstream" patch is what should > fast-track to master/maint and be in 2.13.2, the other two are the > cooking submodule use, that's all unchanged aside from of course the > submodule pointing to the same upstream commit as the code import > itself does. > > Junio: There's a whitespace change to sha1.h that am warns about, but > which it applies anyway that you didn't apply from my previous > patch. I think it probably makes sense to just take upstream's > whitespace shenanigans as-is instead of seeing that diff every time we > update. I guess we could also send them a pull request... I would suggest the pull request. Also as to not make the mistake from before that I jump on the submodule bandwagon here: Patch 1 ought to go in its on series/patch, so with that out the way we have more time to consider the pros and cons of the rest of the series? Thanks, Stefan