Re: [PATCH 06/31] repo: introduce the repository object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> > +
>> > +       repo_set_gitdir(repo, resolved_gitdir);
>> > +
>> > +       /* NEEDSWORK: Verify repository format version */
>>
>> Care to elaborate on this? I do not understand why we would want
>> to check the format version here?
>
> When opening up a repository git needs to check if it understands the
> repository format and all extensions.  If it doesn't git needs to bail
> out and not operate on the repository.  So a part of initializing a repo
> object would be to verify that it understands the repository format
> version.

Ah yes. Conceptually I understand why and what the repo format
version check is. At the time of asking the question I was confused
whether this is the right place, but after some thought this is the
best place to put it.

And this NEEDSWORK is really just telling the reader that it needs to
be moved here, not copied. (That was another brain fart I had upon
reading this comment).

Thanks,
Stefan



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]