On Mon, Jun 5, 2017 at 3:55 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> Realistically I'm going to submit this patch, I'm not going to take >> the much bigger project of refactoring the entire test suite so that >> no test runs under N second, and of course any such refactoring can >> only aim for a fixed instead of dynamic N. > > I do not expect any single person to tackle the splitting. I just > wished that a patch inspired by this patch (or better yet, a new > version of this patch) made the tail end of "make test" output to > read like this: > > ... > [18:32:44] t9400-git-cvsserver-server.sh ...... ok 18331 ms > [18:32:49] t9402-git-cvsserver-refs.sh ........ ok 22902 ms > [18:32:49] t9200-git-cvsexportcommit.sh ....... ok 25163 ms > [18:32:51] > All tests successful. > Files=785, Tests=16928, 122 wallclock secs ( ... > Result: PASS > > * The following tests took longer than 15 seconds to run. We > may want to look into splitting them into smaller files. > > t3404-rebase-interactive.sh ... 19 secs > t9001-send-email.sh ........... 22 secs > t9402-git-cvsserver-refs.sh ... 22 secs > t9200-git-cvsexportcommit.sh .. 25 secs > > when the hidden feature is _not_ used, so that wider set of people > will be forced to see that some tests take inordinate amount of > time, and entice at least some of them to look into it. I wonder if splitting tests would make a good GSoC microproject for next year.