On Sat, Jun 3, 2017 at 3:31 PM, Jakub Wilk <jwilk@xxxxxxxxx> wrote:
> The file is syntactically correct only in Python >= 2.6, so the
> version check never does anything.
[CC-ing Eric who added that check]
Your commit message doesn't give an example of this, but with e.g.
python 2.0 you get:
File "git-p4.py", line 469
yield pattern
^
SyntaxError: invalid syntax
I checked the various other python files that had similar warnings,
they all work correctly with python 2.0.
One workaround to keep this would be to make git-p4.py import some
library to do all its work, and use some subset of python syntax to
just load and defer to that library. That works for me when I change
it like that locally. Alternatively, does Python have something like
Perl's BEGIN {} blocks where you can execute code right there before
the file has finished parsing?
Or we could just remove this, just wanted to note the above since I
dug into it, and the commit message light on details.
> Signed-off-by: Jakub Wilk <jwilk@xxxxxxxxx>
> ---
> git-p4.py | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/git-p4.py b/git-p4.py
> index 8d151da91..4278cd9d4 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -8,10 +8,6 @@
> # License: MIT <http://www.opensource.org/licenses/mit-license.php>
> #
> import sys
> -if sys.hexversion < 0x02040000:
> - # The limiter is the subprocess module
> - sys.stderr.write("git-p4: requires Python 2.4 or later.\n")
> - sys.exit(1)
> import os
> import optparse
> import marshal
> --
> 2.13.0.506.g27d5fe0cd
>