On 05/31, brian m. carlson wrote: > On Tue, May 30, 2017 at 10:30:36AM -0700, Brandon Williams wrote: > > A month or so ago I thought I would lend a hand to Brian and do a round of > > conversions from sha1 -> struct object_id. Now that Brian's latest series has > > hit master I can finally send these patches out. > > > > The first couple patches are from Brian which convert some of the notes logic > > to using 'struct object_id'. The remaining patches are to convert the grep and > > diff machinery to using 'struct object_id'. > > > > Brandon Williams (26): > > grep: convert to struct object_id > > diff: convert get_stat_data to struct object_id > > diff: convert diff_index_show_file to struct object_id > > diff: convert diff_addremove to struct object_id > > diff: convert run_diff_files to struct object_id > > diff: convert diff_change to struct object_id > > diff: convert fill_filespec to struct object_id > > diff: convert reuse_worktree_file to struct object_id > > diff: finish conversion for prepare_temp_file to struct object_id > > patch-ids: convert to struct object_id > > diff: convert diff_flush_patch_id to struct object_id > > combine-diff: convert diff_tree_combined to struct object_id > > combine-diff: convert find_paths_* to struct object_id > > tree-diff: convert diff_root_tree_sha1 to struct object_id > > notes-merge: convert notes_merge* to struct object_id > > notes-merge: convert merge_from_diffs to struct object_id > > notes-merge: convert find_notes_merge_pair_ps to struct object_id > > notes-merge: convert verify_notes_filepair to struct object_id > > notes-merge: convert write_note_to_worktree to struct object_id > > diff-tree: convert diff_tree_sha1 to struct object_id > > I've wanted to convert this function for some time. I'm glad you got > around to it. Of course, glad to help! After working on this stuff I realized how serial this sort of conversion can be since its easy to have a function span many many parts of the code base. > > Other than the issue I pointed out, the fact that I'm obviously not > qualified to review my own patches, and the issue that Stefan pointed > out with GIT_MAX_HEXSZ, this looks good to me. > -- > brian m. carlson / brian with sandals: Houston, Texas, US > https://www.crustytoothpaste.net/~bmc | My opinion only > OpenPGP: https://keybase.io/bk2204 -- Brandon Williams