Re: [PATCH 6.5?/8] version: move --build-options to a test helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 31, 2017 at 05:27:21PM +0200, Johannes Schindelin wrote:

> > My intent in putting it into the actual git binary was that it could
> > also be useful for collecting build-time knobs from users (who may be
> > using a binary package). Like:
> > 
> >   http://public-inbox.org/git/20160712035719.GA30281@xxxxxxxxxxxxxxxxxxxxx/
> > 
> > We haven't filled in that NEEDSWORK yet, but I'd rather see us go in
> > that direction than remove the option entirely.
> 
> FWIW it also helped Git for Windows.
> 
> The two additional bits we added to the build options (the commit from
> which Git was built and the architecture) did not hurt one bit, either.
> 
> In other words, it would make my life a lot harder if --build-options were
> moved to a test helper that does not ship with the end product.

Cool, I'm glad it has helped already. If you have further bits added to
the output, is it worth sending that patch upstream?

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]