On Thu, May 25, 2017 at 3:55 PM, Ben Peart <peartben@xxxxxxxxx> wrote: > > On 5/24/2017 6:54 AM, Christian Couder wrote: >>> >>> A new git hook (query-fsmonitor) must exist and be enabled >>> (core.fsmonitor=true) that takes a time_t formatted as a string and >>> outputs to stdout all files that have been modified since the requested >>> time. >> >> Is there a reason why there is a new hook, instead of a >> "core.fsmonitorquery" config option to which you could pass whatever >> command line with options? > > A hook is a simple and well defined way to integrate git with another > process. If there is some fixed set of arguments that need to be passed to > a file system monitor (beyond the timestamp stored in the index extension), > they can be encoded in the integration script like I've done in the Watchman > integration sample hook. Yeah, but a hook must also be called everytime git wants to communicate with the file system monitor. And we could perhaps get a speed up if we could have only one long running process to communicate with the file system monitor.