Stefan Beller <sbeller@xxxxxxxxxx> writes: > On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Do we have any reasons for that, or pointers on the mailing list, that this > is a good idea or needed? Does it fix a bug or enable a new feature on Darwin? BSD lets you open() a directory for reading and hence we require this workaround on it; I think somebody in an earlier round suspected that that Darwin would have inherited the same from its BSD lineage, and I don't see a reason to contradict with that suspicion, either. > >> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> >> --- >> config.mak.uname | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/config.mak.uname b/config.mak.uname >> index a25ffddb3e..1743890164 100644 >> --- a/config.mak.uname >> +++ b/config.mak.uname >> @@ -110,6 +110,7 @@ ifeq ($(uname_S),Darwin) >> BASIC_CFLAGS += -DPRECOMPOSE_UNICODE >> BASIC_CFLAGS += -DPROTECT_HFS_DEFAULT=1 >> HAVE_BSD_SYSCTL = YesPlease >> + FREAD_READS_DIRECTORIES = UnfortunatelyYes >> endif >> ifeq ($(uname_S),SunOS) >> NEEDS_SOCKET = YesPlease >> -- >> 2.13.0-491-g71cfeddc25 >>