Junio C Hamano <junkio@xxxxxxx> writes: > Frank Lichtenheld <frank@xxxxxxxxxxxxxx> writes: > >> On Fri, May 11, 2007 at 04:35:18PM -0700, Junio Hamano wrote: >>> This needs to be fixed, but thanks to that bug, a separate bug >>> in t9400 test script was discovered. The test discarded >>> GIT_CONFIG instead of pointing at the proper one to be used in >>> the exoprted repository. This allowed user's .gitconfig and (if >>> exists) systemwide /etc/gitconfig to affect the outcome of the >>> test, which is a big no-no. >> >> Shouldn't you also remove the "unset GIT_CONFIG" then? > > I didn't test the side of the test that works on the git side, > but I think you are right. Actually that is not sufficient, as unsetting means using the value set in test-lib.sh suitable for usual single-repository tests. When you prepare gitcvs.enabled config in the cloned gitcvs.git repository, you do not want to have GIT_CONFIG=.git/config in the environment. As you give GIT_DIR to these two commands, not having GIT_CONFIG would make them do the right thing. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
