Hi, On Thu, 10 May 2007, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Signed-off-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx> > > > > --- > > > > t/t5000-tar-tree.sh | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh > > index e223c07..1580592 100755 > > --- a/t/t5000-tar-tree.sh > > +++ b/t/t5000-tar-tree.sh > > @@ -108,6 +108,13 @@ test_expect_success \ > > 'git-archive --format=zip' \ > > 'git-archive --format=zip HEAD >d.zip' > > > > +unzip -v 2>/dev/null > > +if [ $? -ne 10 ]; then > > + echo "Skipping ZIP tests, because unzip was not found" > > + test_done > > + exit > > +fi > > + > > Are you sure about this? No longer. At least one unzip version I tested returned exit code 10 when correctly showing the usage (IIRC). However, another one has exit code 0! Also, it should not hardcode "unzip", but instead use "$UNZIP". So, please ignore this patch. I try to do it properly. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
