Re: [GSoC][PATCH v5 3/3] submodule: port subcommand foreach from shell to C

[Stefan Beller <sbeller@xxxxxxxxxx>]

On Fri, May 26, 2017 at 8:17 AM, Prathamesh Chavan <pc44800@xxxxxxxxx> wrote:
> This aims to make git-submodule foreach a builtin.

Cool. I reviewed the code and only have one minor nit.

> +static void runcommand_in_submodule(const struct cache_entry *list_item,
> +                                   void *cb_data)
> +{

> +       /* Only loads from .gitmodules, no overlay with .git/config */
> +       gitmodules_config();

Performance nit: We only need to load the gitmodules file once instead
of foreach submodule separately, so we could move this to module_foreach().

Thanks,
Stefan