On Sun, May 21, 2017 at 1:50 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> diff --git a/t/perf/README b/t/perf/README >> index 49ea4349be..b3d95042a8 100644 >> --- a/t/perf/README >> +++ b/t/perf/README >> @@ -60,8 +60,23 @@ You can set the following variables (also in your config.mak): >> >> GIT_PERF_MAKE_OPTS >> Options to use when automatically building a git tree for >> - performance testing. E.g., -j6 would be useful. >> - >> +... >> + any of that, that's an implementation detail that might change >> + in the future. >> + > > I'll remove the trailing whitespace on this otherwise blank line > while queuing (no need to resend only to fix this one). > > Thanks. Thanks, forgot about diff --check on the whole series with all the other checks I was doing. >> GIT_PERF_REPO >> GIT_PERF_LARGE_REPO >> Repositories to copy for the performance tests. The normal >> diff --git a/t/perf/run b/t/perf/run >> index c788d713ae..b61024a830 100755 >> --- a/t/perf/run >> +++ b/t/perf/run >> @@ -37,8 +37,15 @@ build_git_rev () { >> cp "../../$config" "build/$rev/" >> fi >> done >> - (cd build/$rev && make $GIT_PERF_MAKE_OPTS) || >> - die "failed to build revision '$mydir'" >> + ( >> + cd build/$rev && >> + if test -n "$GIT_PERF_MAKE_COMMAND" >> + then >> + sh -c "$GIT_PERF_MAKE_COMMAND" >> + else >> + make $GIT_PERF_MAKE_OPTS >> + fi >> + ) || die "failed to build revision '$mydir'" >> } >> >> run_dirs_helper () {