On 18/05/17 22:21, Johannes Schindelin wrote:
> Hi Phillip,
>
> On Thu, 18 May 2017, Phillip Wood wrote:
>
>> From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx>
>>
>> The message that's printed when auto-stashed changes are successfully
>> restored was missing '\n' at the end.
>> ---
>
> Please add your Signed-off-by:, and my Acked-by:
Will do (I forgot to add --signoff to git commit). Do I need to resend
the other patches with your Acked-by: or will that happen when Junio
applies them?
I was thinking about this last night and wonder if it would be better to do
- printf(_("Applied autostash."));
+ printf("%s\n", _("Applied autostash."));
rather than
- printf(_("Applied autostash."));
+ printf(_("Applied autostash.\n"));
as it would avoid changing the translated string and also mean that the
newline couldn't be accidentally removed any typos in the translation.
Best Wishes
Phillip