On 05/17, Stefan Beller wrote: > On Wed, May 17, 2017 at 12:33 PM, Ævar Arnfjörð Bjarmason > <avarab@xxxxxxxxx> wrote: > > On Wed, May 17, 2017 at 12:19 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> > >>>> Well, it is one thing to place git-annex under CI to make sure its > >>>> latest and greatest works together well with our latest and greatest > >>>> (and it may be something we want to see happen), but driving its > >>>> tests from our testsuite sounds like a tail wagging the dog, at > >>>> least to me. > >>> > >>> To me this is just a question of: > >>> > >>> * Is it the case that git-annex tests for a lot of edge cases we don't > >>> test for: Yes, probably. As evidenced by them spotting this > >>> regression, and not us. > >> > >> And I'd encourage them to keep doing so. > > > > The point of this patch is that we can do this more systematically and > > reliably, not have people discover this sort of thing after a major > > release. > > > > I.e. we can be pro-active about this instead of waiting for bug > > reports to roll in. > > We can be pro-active without this patch, too. ;) > I guess this makes it just easier for someone out of the Git community to > be proactive in searching for defects. > > > > > The utility of this test is that sometime close to release someone > > (e.g. me) can run it, if it fails let's see if it fails on the last > > release version of ours, if so it's probably upstream breakage, or > > like with the 2.13.0 release if it's OK on 2.12.0 it's our bug. > > > > It'll never trip some random tester up since you need to explicitly > > opt-in via EXTERNAL_TESTS=1, so honestly I'm a bit puzzled by these > > objections. This incurs no burden on either devs, packagers or users, > > and would have demonstrably detected an issue we'd rather have wanted > > to know about pre-release than post-release as is the case now. > > I think this patch could spark a discussion what we expect from our test suite. > Is it a contract that we promise, as in "Here are some blessed workflows, > our users should see and imitate"? > > This patch sort of feels like (a) we let others dictate the contract to us > and (b) we choose the easy way out as we do not write enough tests on > our own, so we force downstream to help us out. > > I guess it is appropriate to compare this level of testing to other external > tests, such as cppcheck, travis, coverity. For some of them (travis) we > carry some code with us (.travis), not so for others (coverity would benefit > from [1] that I carry outside of Junios tree). Admittedly these external tools > are all focused on testing, not on building on top of Git, which brings > in other expectations from these tools. > > [1] https://github.com/stefanbeller/git/commit/0781fbafb9dd2a995ba62a9af5f7581e3cf05359 > > --- > As mentioned in the other thread[2], the idea was floated to have this test or > the downstream project as a submodule, and if you are interested in the test, > then you would obtain the submodule and run the tests (in there?) Despite working on improving submodules, I'm still very skeptical of adding submodules to git.git, at least at this point in time. I just feel like the submodule experience still has a lot of work before we begin using it...Though My feeling may be completely unfounded. > That would have the benefit of less 'uninteresting' glue logic for those who > are not interested in these tests as gitlinks may be easier to ignore > for a developer > than code. (Less data to fetch, git-grep also doesn't yield results > for the uninteresting > parts as these submodules would be uninitialized). > (The more I talk about this "downstream tests in submodules" > idea, the less convinced I am) > > [2] https://public-inbox.org/git/20170517113824.31700-1-avarab@xxxxxxxxx/ -- Brandon Williams