On 05/17/2017 02:42 PM, Jeff King wrote: > On Wed, May 17, 2017 at 02:05:24PM +0200, Michael Haggerty wrote: > >> The test of failing `git rm -f` removes the write permissions on the >> test directory, but fails to restore them if the test fails. This >> means that the test temporary directory cannot be cleaned up, which >> means that subsequent attempts to run the test fail mysteriously. >> >> Instead, do the cleanup in a `test_must_fail` block so that it can't >> be skipped. > > This should be `test_when_finished` in the final paragraph, right? Yes, thanks. Will fix. Michael