On May 10, 2007, at 10:30 PM, Junio C Hamano wrote:
I do not either, and obviously does not reproduce for me. Time
for you to try "make -d" perhaps?
Sorry for the semi-coherent message. It started out as "we should
fix this" and I ended up going "why is it broken", all a little too
late at night. I'm also not used to debugging Makefiles.
And I figured it out (make -p actually was more useful than -d):
It's another issue with doing things before including config.mak. My
config.mak includes the "NO_TCLTK=y" line, which takes effect at
Makefile:485. But gitk-wish is getting included in OTHER_PROGRAMS at
Makefile:272. So gitk-wish gets included because NO_TCLTK isn't
defined at that point, but all the other rules involving gitk don't
get executed because they're after the NO_TCLTK definition.
I think we need to be including the config.mak much earlier in the
Makefile as this is not the first time issues like this have come up
for me. And they tend to be issues that only come up with specific
configurations and are therefore harder to track down. Things I can
see being an issue for people who put their options in config.mak:
149: ifeq ($(prefix),/usr)
224: ifdef WITH_P4IMPORT
271: ifndef NO_TCLTK # My issue today
279-285: ifndef {SHELL,PERL,PYTHON}_PATH
~~ Brian
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
