On Mon, May 15, 2017 at 01:05:53PM +0200, SZEDER Gábor wrote: > This is a reroll of sg/clone-refspec-from-command-line-config. > Sorry for the delay, family visit. No problem. Thanks for letting us know before it went to 'next'. ;) > The first patch is the updated version of what is now the first commit > of that topic. The changes are those mentioned in [1]: > > - updated commit message, > - renamed 'refspec_count' to 'refspec_nr', Good. > - use the parsed fetch refspecs returned by remote.c:remote_get() > instead of parsing them ourselves (look at the third hunk of the > diff of builtin/clone.c, how much shorter it looks), Yeah, that is much nicer. It does feel a little dirty modifying remote->fetch, though. I'll comment on the specific patch. > - modified tests to check that refs matching the default refspecs are > transferred as well, and > - added a test for the combination of '-c > remote.<remote>.fetch=<refspec> --origin=<name>'. Sounds good. > The second patch is a doc update to warn users that not all > configuration variables are supported via 'git clone -c ...' at the > moment. Good idea. > Patches 3 and 4 are the last two patches from Peff from this morning > [2]. I picked those up, because his last patch required a bit of > variable name adjustments. I didn't pick up his first patch, because > using remote_get() already factors out refspec parsing. Makes sense. Thanks for including them. -Peff