Hi Junio, On Mon, 15 May 2017, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > > Thanks for the hotfix. I'll fix this in my v2, but do it differently > > in such a way that I can still run these tests on windows. > > > > I.e. the actual test here just needs these odd characters in the > > commit message. It's just an unintended implementation detail of > > test_commit that a tag is being created. > > My knee-jerk reaction matched Dscho's, but grep is about contents, > and we should be able to test this if we used a sensible tagnames or > didn't use any. Glad to see somebody can step back and think ;-) Maybe somebody should step back even further and think even more, as we could adjust test_commit to mangle the argument into a tag name that is legal even with a refs backend relying on NTFS. Ciao, Dscho