On Fri, May 12, 2017 at 6:59 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> Amend the submodule recursion test to prepare it for subsequent tests >> of whether it passes along the grep.patternType to the submodule >> greps. >> >> This is the result of searching & replacing: >> >> foobar -> (1|2)d(3|4) >> foo -> (1|2) >> bar -> (3|4) >> ... >> test_expect_success 'grep and multiple patterns' ' >> cat >expect <<-\EOF && >> - b/b:bar >> + b/b:(3|4) >> EOF >> >> - git grep -e "bar" --and --not -e "foo" --recurse-submodules >actual && >> + git grep -e "(3|4)" --and --not -e "(1|2)d" --recurse-submodules >actual && > > > This breaks the promise "foo maps to (1|2)"; I do not think you need > to add 'd' in order to make the test to succeed, so I am not sure > what is going on here. Thanks, fixing it. That was just a stupid mistake on my part, don't know how that snuck in there, must have just fat-fingered (1|2) as (1|2)d during interactive replace.