On Mon, May 08, 2017 at 10:58:46AM +0900, Junio C Hamano wrote: > Will queue; during the pre-release freeze, new things would move > slowly, but let's see if we have more comments from others and then > merge it to 'next' soon after the 2.13 final. I gave it a fresh read-through. I had a few comments, but nothing that I think should hold up moving these patches to 'next'. I do find the convert/sub-process split a little funny. Most of the protocol bits from convert didn't get moved over, and you could use a sub-process that spoke any arbitrary protocol. The odd man out is subprocess_read_status(), which assumes not only pktlines, but also a "status=foo" key/value pair inside them. I have a feeling that funny split is because this is a preliminary refactoring step that will have more features built on it, and the end result may be more consistent. We _could_ hold these back and pass judgement once we see more. But they're a reasonable-sized chunk that's already been through 7 rounds of review. It makes sense to me to graduate them at least to 'next' and let the next steps use them as a stable base. -Peff