Re: [PATCH] C style: use standard style for "TRANSLATORS" comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 11.05.2017 um 23:20 schrieb Ævar Arnfjörð Bjarmason:
diff --git a/builtin/notes.c b/builtin/notes.c
index 7b891471c4..fb856e53b6 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c
@@ -340,8 +340,10 @@ static struct notes_tree *init_notes_check(const char *subcommand,
ref = (flags & NOTES_INIT_WRITABLE) ? t->update_ref : t->ref;
  	if (!starts_with(ref, "refs/notes/"))
-		/* TRANSLATORS: the first %s will be replaced by a
-		   git notes command: 'add', 'merge', 'remove', etc.*/
+		/*
+		 * TRANSLATORS: the first %s will be replaced by a git
+		 * notes command: 'add', 'merge', 'remove', etc.
+		 */

Rewrapping lines is generally frowned upon because it makes it difficult to see whether something was changed. Keeping the line wrapping will also reduce the noise in the next .pot commit, I think (not sure if that is a worthwhile goal, though).

<rant>
I hate it when J. Random Developer insists in a particular line length and when they have their editor do the wrapping, logical entities are suddenly split into two lines: it is "git notes", one logical thing; not two words "git" "notes" that happen to occur in sequence.
</rant>

-- Hannes



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]