This is another conversion series to convert the pathspec library code to take in an index parameter instead of relying on cache macros or on the global variable 'the_index'. While I was working in the pathspec code I thought it would be good to do a little more cleanup and make the API cleaner. More specifically consolidating the 'strip submodule slash' flags into a single flag while splitting out the 'submodule leading path' check performed in the expensive case into its own flag. Brandon Williams (8): pathspec: provide a more descriptive die message submodule: add die_in_unpopulated_submodule function pathspec: change PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE flag pathspec: rename PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP pathspec: convert strip_submodule_slash to take an index pathspec: convert find_pathspecs_matching_against_index to take an index pathspec: convert init_pathspec_item to take an index pathspec: convert parse_pathspec to take an index archive.c | 4 +- builtin/add.c | 14 +++--- builtin/blame.c | 2 +- builtin/check-ignore.c | 7 +-- builtin/checkout.c | 2 +- builtin/clean.c | 2 +- builtin/commit.c | 4 +- builtin/grep.c | 2 +- builtin/ls-files.c | 6 +-- builtin/ls-tree.c | 5 ++- builtin/rerere.c | 2 +- builtin/reset.c | 4 +- builtin/rm.c | 4 +- builtin/submodule--helper.c | 4 +- builtin/update-index.c | 2 +- line-log.c | 2 +- pathspec.c | 92 +++++++++++++++++----------------------- pathspec.h | 19 +++++---- revision.c | 5 ++- submodule.c | 32 +++++++++++++- submodule.h | 2 + t/t6134-pathspec-in-submodule.sh | 6 +-- tree-diff.c | 2 +- 23 files changed, 122 insertions(+), 102 deletions(-) -- 2.13.0.rc2.291.g57267f2277-goog