Hi Duy, On Tue, 9 May 2017, Duy Nguyen wrote: > Sorry for super late reply. I'm slowly catching up. > > On Wed, May 3, 2017 at 10:22 PM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > Hi Duy, > > > > > > On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > > > >> There's plenty of error() in this code to safely assume --quiet is not a > >> concern. > >> > >> t5512 needs update because if we check the path 'refs*master' (i.e. the > >> asterisk is part of the path) then we'll get an EINVAL error. > > > > So the first change in this patch unmasks a bug that is fixed by the > > second patch? > > The change in read_branches_file() in this patch causes the failure. > See the original report [1], > > [1] http://public-inbox.org/git/3a2686c2-6766-1235-001f-1b5283b5f408@xxxxxxxx/ I disagree. I do not think that the first part of the patch causes the failure. I think the failure was always there, we just did not bother to report (and catch) it properly. Ciao, Dscho