Jeff King <peff@xxxxxxxx> writes: > Actually, it's not too bad, because we can pick up things like > option_origin from the globals. Here it is for reference. The nice thing > about it (IMHO) is that it makes the lifetimes of the helper variables > much more shorter and more clear. > > But I'm OK with any of Gábor's original, my earlier squash, or this one. > > (Also, as a side note, the free(refspec) in the context at the bottom > seems like it probably ought to be free_refspec() in the original and > free_refspecs() after this change, but I didn't investigate). I'll tentatively queue this on top of the original and wait for Gábor to say something, then ;-) as I do agree that this one looks reasonable. Thanks.