On Mon, May 08, 2017 at 09:26:11PM +0200, Дилян Палаузов wrote: > Click on https://mail.aegee.org/dpa/scan-build-git-4fa66c85f11/ and > then on "fast-import.c: line 2057 -> View Report" and you will see > pointless assignment. > > I cannot organize the report much better, as filtering out the false > positives requires usually too deep understanding of the code > organization of git, which I do not have. Right, but I think Johannes's point is that we already know about scan-build. It's been discussed on the list multiple times. The next step is somebody actually looking at each reported issue, fixing any problematic ones, and suppressing (or at least cataloging) the false positives. Here's a link to the last discussion on this topic, from a few months ago: http://public-inbox.org/git/CAJZjrdXP3n5fOLx4rEEkbJT7JBMPUqk4Qdutm6KpvMVUMwCSPQ@xxxxxxxxxxxxxx/T/#u It even involves a Travis build. :) -Peff